Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set socket connection timeout #570

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@fkorotkov
Copy link
Contributor

fkorotkov commented Sep 6, 2019

It seems that on Cirrus create_connection frequently times out on the first try but succeeds on the second try. The default timeout is 60 seconds which seems too much for just checking availability of a port. This change set default timeout to 1 second which helps mitigate the issue of frequent socket timeouts on the first attempt.

It seems that on Cirrus `create_connection` frequently times out on the first try but succeeds on the second try. The default timeout is 60 seconds which seems too much for just checking availability of a port. This change set default timeout to 1 second which helps mitigate the issue of frequent socket timeouts on the first attempt.
@mavam mavam requested a review from tobim Sep 6, 2019
@tobim
tobim approved these changes Sep 9, 2019
Copy link
Member

tobim left a comment

Thank you for digging into this and implementing this workaround!

@tobim tobim merged commit 5368e75 into tenzir:master Sep 9, 2019
6 checks passed
6 checks passed
Debian BUILD_TYPE:Debug CONFIGURE_FLAGS:--enable-asan Task Summary
Details
Debian BUILD_TYPE:Release Task Summary
Details
FreeBSD BUILD_TYPE:Debug CONFIGURE_FLAGS:--enable-asan Task Summary
Details
FreeBSD BUILD_TYPE:Release Task Summary
Details
macOS - Release Task Summary
Details
style Task Summary
Details
@fkorotkov fkorotkov deleted the fkorotkov:patch-2 branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.