Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper logging support. #6

Closed
teo-tsirpanis opened this issue Jun 13, 2019 · 1 comment
Closed

Add proper logging support. #6

teo-tsirpanis opened this issue Jun 13, 2019 · 1 comment
Assignees
Milestone

Comments

@teo-tsirpanis
Copy link
Owner

The event callbacks acceptd by RuntimeFarkle are not an option. I'm talking about integration with a real logging framework. This will allow gathering much deeper insights about Farkle's internal workings. Furthermore, it might even pave the way for localized log messages! This framework has to be fast (i.e. minimal overhead when no logging is enabled), and have an easy-to-use API.

I am leaning towards either logary, or Serilog, or maybe something else.

@teo-tsirpanis teo-tsirpanis self-assigned this Jun 13, 2019
@teo-tsirpanis teo-tsirpanis added this to the Version 5 milestone Jun 13, 2019
@teo-tsirpanis teo-tsirpanis pinned this issue Jun 13, 2019
@teo-tsirpanis teo-tsirpanis unpinned this issue Jun 13, 2019
@teo-tsirpanis
Copy link
Owner Author

I changed my mind.

The way Farkle logs messages is extremely flexible; it allows any logging framework to integrate, and does that without any support from 3rd-party logging frameworks. Consumers just pass a function that logs the message in any framework they want.

What is more, the logging message type is structural logging at its finest form.

@teo-tsirpanis teo-tsirpanis closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant