This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Feature: Ability to seek track to specific millisecond #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify that the duration is given in seconds.
|
Please resolve the conflicts and then I'll review the changes |
|
Sorry, my personal laptop broke and I've just had no time to do this, but sure, I'll do it as soon as I can get around to it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For shorter audio tracks, it can be useful to give the ability to seek to milliseconds (rather than seconds) so that the user has more granular control. Seeking to seconds on a very short audio track (such as a voice-recorded chat message which lasts only for a few seconds) can cause sliders which update based on the track's playback point to appear jumpy. Seeking to milliseconds instead allows for such UI interactions to be much smoother.