Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Feature: Add ability to set custom metadata on JukeboxItem. #56

Closed
wants to merge 3 commits into from

Conversation

msaps
Copy link

@msaps msaps commented Jan 16, 2017

Adds JukeboxItemMetaBuilder to allow for custom metadata to be specified for a JukeboxItem. A new public customMetaBuilder property is available on JukeboxItem; simply provide this with a builder with your custom data.

Custom metadata takes precedence over any collected from AVMetadataItem, however a combination of the two is still evaluated and used where appropriate.

Resolves #41.

@wenbinf
Copy link

wenbinf commented Jan 31, 2017

Any plan to merge this PR?

@almatri
Copy link

almatri commented Feb 4, 2017

Any plan to merge this PR? It is really helpful !!.

@teodorpatras
Copy link
Owner

teodorpatras commented Mar 13, 2017

Hey, sorry for the late response, I have been really busy lately. First of all thank you for the PR, secondly, why not make the meta structure public and allow for injecting it from the outside into the JukeboxItem?

I see your builder is a clone of the Meta structure, why not change the existing meta structure?

- Add JukeboxItem.MetaBuilder class to replace JukeboxItemMetaBuilder
@msaps
Copy link
Author

msaps commented Mar 13, 2017

@teodorpatras no worries 👍

I've just gone back and updated the PR with your suggestions:

  • JukeboxItem.MetaBuilder now inherits from JukeboxItem.Meta and overrides the various properties that should be configurable.
  • customMetaBuilder still works the same, allowing for a combination of the MPMediaItem metadata and any custom specified meta to be utilised.
  • JukeboxItem.Meta and JukeboxItem.MetaBuilder are now in a JukeboxItem extension in JukeboxItemMeta.swift.

Cheers 😄

@madlyn
Copy link

madlyn commented Jun 7, 2017

How can I get msaps new feature?

@ghost
Copy link

ghost commented Aug 17, 2017

Has anyone been able to use custom meta data for lock screen and control center.

@msaps msaps closed this Nov 14, 2019
@demetrio812
Copy link

@msaps is the project still maintained? Why has this being closed? Thanks

@msaps
Copy link
Author

msaps commented Nov 15, 2019

@demetrio812 I was just cleaning up my open PR's - this has been open for about 3 years so I assumed it wasn't being maintained any further.. 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do you add your own UIImage as JukeboxItem artwork?
6 participants