Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with bulma css framework #123

Closed
Loque18 opened this issue Aug 20, 2021 · 3 comments
Closed

Incompatibility with bulma css framework #123

Loque18 opened this issue Aug 20, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Loque18
Copy link

Loque18 commented Aug 20, 2021

First of all I want to thank for this wonderfull library. and now going straight to the issue there is a div with a class named "notification" which is a component in bulma css framework https://bulma.io/documentation/elements/notification/

    return (
      <div
        ref={this.rootElementRef}
        onClick={click ? this.onClick : null}
        className="notification"
        style={parentStyle}
        onAnimationEnd={onAnimationEnd}
        onTransitionEnd={onTransitionEnd}
        onTouchStart={touchEnabled ? this.onTouchStart : null}
        onTouchMove={touchEnabled ? this.onTouchMove : null}
        onTouchEnd={touchEnabled ? this.onTouchEnd : null}
      >
        {content ? this.renderCustomContent() : this.renderNotification()}
      </div>
    );

please consider changing the name of that class

@teodosii
Copy link
Owner

Hey, thanks for reporting it. I'm not sure when but I'll put this with next release

@teodosii teodosii added the enhancement New feature or request label Sep 16, 2021
@Loque18
Copy link
Author

Loque18 commented Sep 17, 2021

Hey, thanks for reporting it. I'm not sure when but I'll put this with next release

Thank you so much for answering! Meanwhile for anyone else facing this problem, I suggest changing the class name for notification component in Bulma library, is located in /master/sass/elements/notification.sass

https://github.com/jgthms/bulma/blob/master/sass/elements/notification.sass

@teodosii
Copy link
Owner

teodosii commented Jan 22, 2022

All class are now scoped under rnc_ module, just like animated.css so that it doesn't conflict with other 3rd parties.

Watch for next release, it has this included
@Loque18

Fixed in 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants