Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger notification get's success green background #13

Closed
zilahir opened this issue Feb 5, 2019 · 4 comments
Closed

danger notification get's success green background #13

zilahir opened this issue Feb 5, 2019 · 4 comments

Comments

@zilahir
Copy link

zilahir commented Feb 5, 2019

const variables:

const ERROR = 'DANGER';
const NO_NAME = 'You must provide a name for this calculation!'
addNotification(title, message, type) {
        this.notificationDOMRef.current.addNotification({
          title: title,
          message: message,
          type: type.toLowerCase(),
          insert: "top",
          container: "top-right",
          animationIn: ["animated", "fadeIn"],
          animationOut: ["animated", "fadeOut"],
          dismiss: { duration: 2500 },
          dismissable: { click: true }
        });
      }
this.addNotification(ERROR, NO_NAME, ERROR)

danger_error

@teodosii
Copy link
Owner

teodosii commented Feb 5, 2019

Couldn't reproduce, pretty sure you've messed somehow the styles. Tested in the samples project, replaced TypeExample.js's add with this piece of code and it's working as expected

add() {
  const ERROR = 'DANGER';
  const NO_NAME = 'You must provide a name for this calculation!';
  return this.props.addNotification({
    title: ERROR,
    message: NO_NAME,
    type: ERROR.toLowerCase(),
    insert: "top",
    container: "top-right",
    animationIn: ["animated", "fadeIn"],
    animationOut: ["animated", "fadeOut"],
    dismiss: { duration: 2500 },
    dismissable: { click: true }
  });
}

@teodosii
Copy link
Owner

teodosii commented Feb 7, 2019

Did you manage to fix the issue or is it still reproducing @zilahir ? Without a reproducing repo I cannot really reproduce this as it's working as expected in the samples project - which is the source code for github pages.

@zilahir
Copy link
Author

zilahir commented Feb 7, 2019

@teodosii i did a small hack to be honest:

.notification-danger {
    .notification-message {
        background-color: $warning-text-color !important;
        text-align: left;
    }
}

I did not have time to create a sandbox project and try to reproduce it, so went around the problem myself. Thanks for the reply and the question tho, during the weekend i'll try to reproduce myself in a clean project and see where does that leads.

@teodosii
Copy link
Owner

teodosii commented Feb 8, 2019

I'd suggest you to use custom content as it is a better suit if you want more control over the CSS. I will close this issue for now, feel free to open another issue if you struggle with it or you find another bug.

@teodosii teodosii closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants