Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any typescript support? #65

Closed
SaavanNanavati opened this issue Apr 5, 2020 · 7 comments
Closed

Any typescript support? #65

SaavanNanavati opened this issue Apr 5, 2020 · 7 comments

Comments

@SaavanNanavati
Copy link

No description provided.

@teodosii
Copy link
Owner

teodosii commented Apr 6, 2020

I can't say for now, I'll let it open.

@SarhadSalam
Copy link
Contributor

This is my first time writing a typescript definition file for an external library, but I have worked with typescript for a while.

Seems like there is only 2 publicly accessible API method, do you mind if I make a PR and create a type binding for this?

@teodosii
Copy link
Owner

@SarhadSalam Sure, I will merge the PR when it's available

@SarhadSalam
Copy link
Contributor

@teodosii I actually created a type definition at DefinitelyTyped since I needed it in my project. I will update the readme and include installations instructions!

@teodosii
Copy link
Owner

teodosii commented Oct 1, 2020

Next version is scheduled for the next days, will have typescript included! 🥳

@gretzke
Copy link

gretzke commented Nov 6, 2020

Next version is scheduled for the next days, will have typescript included! 🥳

Is this version 2.4.1? The typings by @SarhadSalam give me an error while creating a new custom type like this:

<ReactNotification types={[{ htmlClasses: ['test-notification'], name: 'test' }]} />

How can I enable typescrip support on the latest version?

@teodosii
Copy link
Owner

Fixed in 3.0.0. Let me know if there's an issue but there should be all the bindings included in the NPM package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants