Improved accuracy and reliability of BoardCell conversions with comprehensive testing #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the
BoardCell
encoding and decoding functions where digits containing 0 were not handled correctly.Specifically, the fix addresses:
-
toInt()
: Ensures that the 'J' character is correctly decoded as 0.-
toBoardCell()
: Handles cases where the integer is composed of digits containing 0 (e.g., 10, 20, etc.).Additionally, this PR introduces unit tests to verify the corrected behavior and ensure future changes maintain the expected functionality.
Using the fixed functions:
Once you've implemented the fixes in
toBoardCell()
andtoInt()
, you can use them directly in your code like this: