Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of numpy.float #286

Closed
doomspec opened this issue May 25, 2023 · 2 comments
Closed

Remove deprecated usage of numpy.float #286

doomspec opened this issue May 25, 2023 · 2 comments

Comments

@doomspec
Copy link
Contributor

numpy.float has been deprecated since NumPy 1.20. When using Python 3.8 with conda automatically installed NumPy, there will be an error in the following code

import numpy
a = numpy.float(1)

The current version of tq includes many such usages
https://github.com/search?q=repo%3Atequilahub%2Ftequila%20numpy.float&type=code

Whenever these codes are executed, the program just stops.

We might need to change all numpy.float to float for higher version numpy

@kottmanj
Copy link
Collaborator

I'm just getting a warning, no error (numpy v.1.23.5). I potentially silenced them.
Updating is however a good idea.
I'll put it on the todo list. If you have time to do it yourself, let me know.

@doomspec
Copy link
Contributor Author

#287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants