Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.io site routing #33

Closed
KiaraGrouwstra opened this issue Aug 4, 2016 · 3 comments
Closed

github.io site routing #33

KiaraGrouwstra opened this issue Aug 4, 2016 · 3 comments

Comments

@KiaraGrouwstra
Copy link
Contributor

This feature request belongs with the github.io covalent site, but afaict the repo for that is private (?).

I tried linking someone to https://teradata.github.io/covalent/style-guide/material-components, as it's a great overview of ng2 MD components (which they don't even have up yet on their official site yet at all). That link fails though -- it seems the routing is still a one-way street for now. I haven't had much experience with the recent ng2 routers yet either, but hope this might get improved at one point. :)

@aciccarello
Copy link
Contributor

Can you do deep linking on a github.io site?

@KiaraGrouwstra
Copy link
Contributor Author

Whoops, good point; since it just 404s rather than giving the index.html SPA, I guess probably not. I'll close then; too bad. :(
I wonder if there'd be a way to similarly file a feature request at Github Pages instead, if they have a repo for that...

@gnomeontherun
Copy link
Contributor

gnomeontherun commented Aug 4, 2016

I have a PR ready to use hash urls to fix this. GitHub doesn't support url
rewrites though we could also use something like cloud flare I think to
help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants