Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert #26

Closed
1 task
kortemik opened this issue Mar 8, 2024 · 2 comments · Fixed by #27
Closed
1 task

Fix code scanning alert #26

kortemik opened this issue Mar 8, 2024 · 2 comments · Fixed by #27
Assignees

Comments

@kortemik
Copy link
Member

kortemik commented Mar 8, 2024

Tracking issue for:

@StrongestNumber9
Copy link
Contributor

Added a WIP PR for it but why is this implemented by string replacing channel and extras? Is the input format defined by external application because that looks fairly weird.

@StrongestNumber9
Copy link
Contributor

Looked into it and it seems like input is arbitrary format json-like strings that are string manipulated later on. This is very fragile approach and I think the input should also be either valid json or as different fields so we can leverage existing tools and methods to do the hard work for us. Currently required param is optional but anything except exact match will cause request body cleaner to return invalid json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants