Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getBytes("UTF-8") with getBytes(StandardCharsets.UTF_8) #33

Open
StrongestNumber9 opened this issue Mar 25, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@StrongestNumber9
Copy link
Contributor

Description

Replace getBytes("UTF-8") with getBytes(StandardCharsets.UTF_8)

Use case or motivation behind the feature request

It doesn't throw when using well defined StandardCharsets -> no need to do try/catch for something that we know is not going to throw

Related issues

Additional context

No: relpBatch.insert(syslogMessage.toRfc5424SyslogMessage().getBytes("UTF-8"));
Yes: relpBatch.insert(syslogMessage.toRfc5424SyslogMessage().getBytes(StandardCharsets.UTF_8));

@StrongestNumber9 StrongestNumber9 added the enhancement New feature or request label Mar 25, 2024
@StrongestNumber9
Copy link
Contributor Author

I think this should be done together with #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant