Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in LoggerFactory.getLogger calls #68

Closed
StrongestNumber9 opened this issue Feb 19, 2024 · 0 comments · Fixed by #75
Closed

Inconsistencies in LoggerFactory.getLogger calls #68

StrongestNumber9 opened this issue Feb 19, 2024 · 0 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@StrongestNumber9
Copy link
Contributor

StrongestNumber9 commented Feb 19, 2024

Describe the bug

src/main/java/com/teragrep/rlp_03/context/buffer/BufferLeaseImpl.java: private static final Logger LOGGER = LoggerFactory.getLogger(BufferLease.class); -> BufferLease.class instead of BufferLeaseImpl.class like in other *Impl classes

src/test/java/com/teragrep/rlp_03/ConnectionStormTest.java: private static final Logger LOGGER = LoggerFactory.getLogger(SendMessageTest.class); -> Wrong logger class

src/test/java/com/teragrep/rlp_03/ManualPerformanceTest.java: private static final Logger LOGGER = LoggerFactory.getLogger(ManualTest.class); -> Wrong logger class

src/test/java/com/teragrep/rlp_03/ManualPerformanceTest.java: private static final Logger LOGGER = LoggerFactory.getLogger(FrameConsumer.class); -> Wrong logger class Subclasses, are as expected

src/test/java/com/teragrep/rlp_03/ManualPerformanceTest.java: private static final Logger LOGGER = LoggerFactory.getLogger(Reporter.class); -> Wrong logger class Subclasses, are as expected

Expected behavior

Loggers are consistent

How to reproduce

grep -Ri "LoggerFactory.getLogger" src/

Screenshots

Software version

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant