Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CI from Travis to Github Actions #1002

Closed
godber opened this issue Jun 8, 2023 · 3 comments
Closed

Convert CI from Travis to Github Actions #1002

godber opened this issue Jun 8, 2023 · 3 comments
Assignees

Comments

@godber
Copy link
Member

godber commented Jun 8, 2023

We need to convert the ES asset CI to Github Actions, the tests currently iterate over opensearch versions and aren't as easy as the other assets (e.g. it's not just yarn test:all). So we will only re-use the shared build/publish workflow and implement a custom test workflow for the time being.

This will probably address the need for a Node 18 build as well:

#999

@godber godber self-assigned this Jun 8, 2023
@godber
Copy link
Member Author

godber commented Jun 9, 2023

I got this partly working:

https://github.com/terascope/elasticsearch-assets/actions/runs/5216071478/jobs/9414485604

I had to disable the node 18 tests in some case, I'll come back and retry those. Also the tests linked to above failed initially and I had to retry about half of them. So it's only "kind of" working at this point.

A question I have for @jsnoble is what can we do to disable the Opensearch instance from starting all of the time. Ideally it would only run in the cases where it is needed.

@godber
Copy link
Member Author

godber commented Jun 14, 2023

Most of this has been completed and merged to master here:

#1003

I have the following concerns or TODOs:

  • we should test builds after tests complete
  • add MacOS test back
  • The Opensearch container startup timeouts are still a known retriable failure that I haven't gotten to the bottom of.

@godber
Copy link
Member Author

godber commented Sep 11, 2023

This is sufficiently done

@godber godber closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant