You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks almost exactly like one of my internal tools 馃槅
I would maybe suggest that since you're shipping code with async syntax, that there's no/little point in shipping a sync version of the code.
This is because having async (and fs.rmdir) in the code at all, even when not imported, forces a Node 7.6+ environment, wherein native async is available.
So, anyone using this lib can/should have an async parent function that awaits this guy. You'd only be dropping support for top-level usage, which is easily fixed anyway.
The text was updated successfully, but these errors were encountered:
This looks almost exactly like one of my internal tools 馃槅
I would maybe suggest that since you're shipping code with
async
syntax, that there's no/little point in shipping a sync version of the code.This is because having
async
(andfs.rmdir
) in the code at all, even when not imported, forces a Node 7.6+ environment, wherein nativeasync
is available.So, anyone using this lib can/should have an
async
parent function thatawait
s this guy. You'd only be dropping support for top-level usage, which is easily fixed anyway.The text was updated successfully, but these errors were encountered: