Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package "engines" support needs updated #159

Closed
KyleAMathews opened this issue May 20, 2019 · 2 comments · Fixed by #160
Closed

Package "engines" support needs updated #159

KyleAMathews opened this issue May 20, 2019 · 2 comments · Fixed by #160

Comments

@KyleAMathews
Copy link

You're still listing node 6 as being supported but are using newer syntax which breaks on Node 6 and some Node 8 versions e.g. gatsbyjs/gatsby#14139

@pieh
Copy link
Contributor

pieh commented May 20, 2019

After some research:

parseInt(process.versions.node, 10) < 8

is problematic here

object spread properties was added to Node in version 8.2.1 (behind --harmony flag) and in 8.6.0 finally for regular usage.

So this check should be looking to serve untranspiled code only on node version >= 8.6 (and not just on 8+).

I'll prepare pull request with fix

@terkelg
Copy link
Owner

terkelg commented May 21, 2019

Fixed in master – pushing a new release asap. Thank you @KyleAMathews and @pieh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants