Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A default property in prompt obect #22

Closed
tunnckoCore opened this issue Feb 28, 2018 · 1 comment
Closed

A default property in prompt obect #22

tunnckoCore opened this issue Feb 28, 2018 · 1 comment
Labels
enhancement New feature or request maybe Might add this in the future

Comments

@tunnckoCore
Copy link

tunnckoCore commented Feb 28, 2018

Heya! ✋

The thing is that there is the initial currently. But i believe it would be better the initial to be set in parens before the . It's cool feature, and it can be used to set default values, but if user dont want the default he need to waste time in deleting it to set another. As about if we have default then it can be shown in parens same as initial (if initial not set) and if user like the default then just to click enter.

One more thing that i'm thinking about is required boolean prop to allow the question to be required or not. If required and not set then throw, end the stream or show message which is kinda related to the discussion in #2 (comment) thread.

If not adding required then validate is good option too. Use case.

@terkelg
Copy link
Owner

terkelg commented Mar 2, 2018

I'll consider adding some visual feedback for initial values but it's very low priority at the moment. Fixing bugs and writing tests is the main focus now. I'll close this for now.

@terkelg terkelg closed this as completed Mar 2, 2018
@terkelg terkelg added enhancement New feature or request maybe Might add this in the future labels Mar 2, 2018
@lukeed lukeed mentioned this issue Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe Might add this in the future
Projects
None yet
Development

No branches or pull requests

2 participants