Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental color switching / Sabaki command spam #45

Closed
Terkwood opened this issue Jul 12, 2019 · 1 comment
Closed

Prevent accidental color switching / Sabaki command spam #45

Terkwood opened this issue Jul 12, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Terkwood
Copy link
Owner

Terkwood commented Jul 12, 2019

This issue appears to be caused by BUGOUT Sabaki spamming a bunch of commands in a row.

Do we need to add a commands array to the GTP Controller shim, and to the WebSocketController? This type of array is present in the node.js GTP module -- see source code

If you trigger a modal dialog in the UI, then the other player triggers a move, the MoveMade event is missed by the UI. This can result in having your player send the wrong color of move. Might be hard to reproduce, but if you see this sort of output in the gateway component...

🤖 92d8dc09 BEEP
🏓 3dc0069d PING   PONG   (273.152ms)
♕ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 4, y: 14 })
♜ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 11, y: 4 })
♖ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 15 })
♞ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 16, y: 14 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 5, y: 5 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 15, y: 15 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 10, y: 10 })
♟ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 17, y: 15 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 16 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 16, y: 17 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 12, y: 16 })
♚ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 15, y: 16 })
♗ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 12 })
♚ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 17, y: 16 })
♙ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 14, y: 6 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 13, y: 12 })
♙ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 8, y: 13 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 14, y: 7 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 5 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 14, y: 5 })
♖ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 15, y: 6 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 6, y: 8 })
♖ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 5, y: 8 })
♚ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 8, y: 8 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 8, y: 6 })
♚ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 13, y: 9 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 13, y: 6 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 17, y: 14 })
♕ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 18, y: 13 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 15, y: 14 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 17, y: 13 })
♞ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 17, y: 12 })
♖ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 17, y: 11 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 18, y: 11 })
♕ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 18, y: 12 })
♚ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 18, y: 10 })
♙ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 17, y: 10 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 17, y: 9 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 18, y: 9 })
♟ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 4, y: 8 })
♕ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 5, y: 7 })
♟ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 9, y: 3 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 9, y: 4 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 13, y: 11 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 14, y: 11 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 14, y: 12 })
♖ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 15, y: 11 })
♟ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 16, y: 11 })
♕ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 10 })
♜ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 15, y: 12 })
♙ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 16, y: 13 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 15, y: 10 })
♗ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 14, y: 10 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 14, y: 9 })
♗ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 15, y: 9 })
♝ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 13, y: 10 })
♔ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 17, y: 8 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 9, y: 9 })
♘ 92d8dc09 MOVE   a68c21bb WHITE Some(Coord { x: 8, y: 10 })
♛ 92d8dc09 MOVE   a68c21bb BLACK Some(Coord { x: 11, y: 13 })
🏓 92d8dc09 PING   PONG   (87.259ms)
@Terkwood Terkwood added the bug Something isn't working label Jul 12, 2019
@Terkwood Terkwood changed the title Prevent accidental color switching Prevent accidental color switching / Sabaki command spam Jul 12, 2019
@Terkwood
Copy link
Owner Author

Terkwood commented Sep 3, 2019

Not sure this is possible anymore.

@Terkwood Terkwood closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant