Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sabaki: Fix corner cases for reconnect #50

Closed
Terkwood opened this issue Jul 14, 2019 · 2 comments
Closed

Sabaki: Fix corner cases for reconnect #50

Terkwood opened this issue Jul 14, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Terkwood
Copy link
Owner

Terkwood commented Jul 14, 2019 •
edited

In some cases, a client will disconnect, and then reconnect thinking that it's the wrong player's move. The Reconnected event exposed by gateway already makes it clear which player should be expected to take a turn next. The client should honor that field in order to avoid deadlocking the game for both players.

Related: #48, #49, & Terkwood/Sabaki#11
@Terkwood Terkwood mentioned this issue Jul 15, 2019
Closed
@Terkwood Terkwood pinned this issue Jul 15, 2019
@Terkwood Terkwood added bug Something isn't working enhancement New feature or request labels Jul 15, 2019
@Terkwood
Copy link
Owner Author

Related: #55 was the root cause for most reconnect events.

@Terkwood Terkwood mentioned this issue Jul 15, 2019
Merged
@Terkwood Terkwood unpinned this issue Jul 16, 2019
@Terkwood Terkwood removed the enhancement New feature or request label Jul 16, 2019
@Terkwood
Copy link
Owner Author

Hasn't recurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Terkwood