Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read character under cursor #58

Open
Keith-S-Thompson opened this issue Jul 19, 2019 · 1 comment
Open

Can't read character under cursor #58

Keith-S-Thompson opened this issue Jul 19, 2019 · 1 comment
Labels
priority:p3 Least prior issue type: theme-bug Issue with theme rendering/theme itself

Comments

@Keith-S-Thompson
Copy link

I usually use the black-on-white scheme, but this issue applies to a number of other color schemes as well.

The theme has:

background: #FFFFFF
foreground: #000000

When the cursor is over a non-blank character, both the cursor and the character are solid black.

I've worked around this by adding:

cursor: #B0B0B0

(and copying the file to $HOME/.termux/color.properties and running termux-reload-settings). This sets the cursor to light gray, which makes for a decent contrast with the foreground and background colors. (Perhaps there's a way to automate selecting the best color.)

More generally, the cursor color should contrast well with both the foreground and background colors.

More ambitiously, I suggest adding a cursortext field, specifying the color of text under the cursor. (PuTTY has a similar feature.) This would require changes in

termux-app/terminal-emulator/src/main/java/com/termux/terminal/TextStyle.java

and probably elsewhere.

@hep-mh
Copy link

hep-mh commented Jul 26, 2019

This also applies to the dracula theme and it is especially noticable if you want to select/copy text. In the latter case, the selected text is just a single-colored block and you cannot read the text that you are selecting.
However, the fix that was suggested by @Keith-S-Thompson also works here.

@MrAdityaAlok MrAdityaAlok added type: bug-report priority:p3 Least prior issue type: theme-bug Issue with theme rendering/theme itself and removed type: bug-report labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Least prior issue type: theme-bug Issue with theme rendering/theme itself
Projects
None yet
Development

No branches or pull requests

3 participants