Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with setup.py bug #1084

Closed
vsoch opened this issue Nov 19, 2021 · 5 comments · Fixed by #1085
Closed

Install with setup.py bug #1084

vsoch opened this issue Nov 19, 2021 · 5 comments · Fixed by #1085

Comments

@vsoch
Copy link
Contributor

vsoch commented Nov 19, 2021

Describe the bug
I'm creating a package for spack, and we cannot install with the traditional setup.py build because package metadata is missing in te setup.py. I am wondering if it would be possible to add?

To Reproduce
Steps to reproduce the behavior:

  1. Download .tar.gz from pypi
  2. build
# This is run from spack, python 3.8.12
python -s setup.py --no-user-cfg' build

4 errors found in build log:
  >> 4     /home/vanessa/Desktop/Code/spack-dev/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/py-setuptools-58.2.0-eky5ahqa
           ys44qh7gkwtp2amv6a34oue2/lib/python3.8/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separate
           d 'author-email' will not be supported in future versions. Please use the underscore name 'author_email' instead
     5       warnings.warn(
  >> 6     /home/vanessa/Desktop/Code/spack-dev/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/py-setuptools-58.2.0-eky5ahqa
           ys44qh7gkwtp2amv6a34oue2/lib/python3.8/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separate
           d 'long-description' will not be supported in future versions. Please use the underscore name 'long_description'
            instead
     7       warnings.warn(
  >> 8     /home/vanessa/Desktop/Code/spack-dev/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/py-setuptools-58.2.0-eky5ahqa
           ys44qh7gkwtp2amv6a34oue2/lib/python3.8/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separate
           d 'long-description-content-type' will not be supported in future versions. Please use the underscore name 'long
           _description_content_type' instead
     9       warnings.warn(
  >> 10    /home/vanessa/Desktop/Code/spack-dev/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/py-setuptools-58.2.0-eky5ahqa
           ys44qh7gkwtp2amv6a34oue2/lib/python3.8/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separate
           d 'home-page' will not be supported in future versions. Please use the underscore name 'home_page' instead
     11      warnings.warn(

Error in terminal

see above! I pre-emptively pasted 😆

Expected behavior
Normally setup.py build should be successful.

Environment you are running Tern on

Ubuntu 20.04, no containers!
Python 3.8.12

Thank you!

@rnjudge
Copy link
Contributor

rnjudge commented Nov 19, 2021

Hi @vsoch - thanks for the issue. We use the setup.cfg file to house our package metadata. Are you able to pull the info from there?

@vsoch
Copy link
Contributor Author

vsoch commented Nov 19, 2021

@rnjudge based on the error message, I do think the install is using setup.cfg (sorry for not realizing this) and the issue is that the fields are deprecated. E.g., here is the long-description:

tern/setup.cfg

Line 12 in 38d5c76

long-description = file: README.md
which should be renamed to long_description.

@vsoch
Copy link
Contributor Author

vsoch commented Nov 19, 2021

I can open a quick PR to test updating these metadata fields.

@vsoch
Copy link
Contributor Author

vsoch commented Nov 19, 2021

Suggested change! #1085

@vsoch
Copy link
Contributor Author

vsoch commented Dec 1, 2021

Thank you for this help! Tern is now added to spack, so people can try out install via there, or if interested in Docker/Singularity containers there is a containerize command to do the same and generate in a dockerfile, or modules too. spack/spack#27599 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants