Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tern 2.2.0 with scancode plugin doesn't list packages anymore #818

Closed
amallayev opened this issue Oct 14, 2020 · 12 comments
Closed

tern 2.2.0 with scancode plugin doesn't list packages anymore #818

amallayev opened this issue Oct 14, 2020 · 12 comments
Assignees
Labels
bug Something went wrong
Milestone

Comments

@amallayev
Copy link

amallayev commented Oct 14, 2020

debian_scancode.json.txt
Hello,

tern 2.1.0 with scancode plugin execution used to produce package listing for PhotonOS, Ubuntu, Debian, SuSE and possibly some others.

With tern 2.2.0 this functionality was removed. Can you please confirm if this was intentional? Just making sure that it is not a bug.

@nishakm
Copy link
Contributor

nishakm commented Oct 14, 2020

Hello,

tern 2.1.0 with scancode plugin execution used to produce package listing for PhotonOS, Ubuntu, Debian, SuSE and possibly some others.

With tern 2.2.0 this functionality was removed. Can you please confirm if this was intentional? Just making sure that it is not a bug.

That's interesting. IIRC, v2.2.0 should have added functionality for scancode to find packages. I will check.
Previously, you needed to run tern in default mode to get the packages and then in scancode mode to get file level licenses. Can you try that method and see if you get back the package listings?

@nishakm
Copy link
Contributor

nishakm commented Oct 14, 2020

So it was merged: #791. I'll have to dig into this more.

@nishakm nishakm added the bug Something went wrong label Oct 14, 2020
@amallayev
Copy link
Author

Running in default mode is no problem with 2.2.0, the package listing works just fine. But with -x scancode I get different results between 2.1.0 and 2.2.0 when scanning Ubuntu 18.04 and Photon 3.0, see attached.

tern 2.2.0 with scancode:

photon-3.0-20200626.tern-scancode.13.10.2020.txt

ubuntu-20.04.tern-scancode.14.10.2020.txt

tern 2.1.0 with scancode:

photon-3.0-20200626.tern-scancode.28.08.2020.txt
ubuntu-20.04.tern-scancode.28.08.2020.txt

@nishakm nishakm added this to the Release 2.3.0 milestone Nov 9, 2020
@nishakm nishakm self-assigned this Nov 10, 2020
@nishakm
Copy link
Contributor

nishakm commented Nov 10, 2020

@amallayev The problem seems to be the way tern runs scancode: scancode -ilpcu --quiet --timeout 300 --json - /path/to/rootfs. This doesn't report any package manifest data. Any idea how to fix this?

@amallayev
Copy link
Author

@nishakm I wonder what changed in the way tern calls scancode, as such problem wasn't present in tern 2.1.0. Was tern 2.1.0 passing own package listing results besides scancode? I am using the release version of scancode, v3.1.1 and I indeed do not see package manifest data collected from rootfs.

@nishakm
Copy link
Contributor

nishakm commented Nov 12, 2020

@nishakm I wonder what changed in the way tern calls scancode, as such problem wasn't present in tern 2.1.0. Was tern 2.1.0 passing own package listing results besides scancode?

Tern can consolidate results, yes. If you run tern report -i image:tag and then tern report -x scancode image:tag you will get a package inventory and file licenses.

I am using the release version of scancode, v3.1.1 and I indeed do not see package manifest data collected from rootfs.

I've asked the question to the scancode community. Let's see what happens.

@nishakm nishakm modified the milestones: Release 2.3.0, Near Future Nov 12, 2020
@rnjudge
Copy link
Contributor

rnjudge commented Jan 31, 2021

@nishakm any update from the scancode community? This is something we may want to fix in 3.0.0.

@nishakm
Copy link
Contributor

nishakm commented Feb 10, 2021

@nishakm any update from the scancode community? This is something we may want to fix in 3.0.0.

Nope. I recall you filed an issue?

@rnjudge
Copy link
Contributor

rnjudge commented Feb 10, 2021

@nishakm any update from the scancode community? This is something we may want to fix in 3.0.0.

Nope. I recall you filed an issue?

Not me. I thought "I've asked a question to the scancode community. Let's see what happens" meant that you filed an issue :) If there's no issue yet, I can open one.

@nishakm
Copy link
Contributor

nishakm commented Feb 10, 2021

@nishakm any update from the scancode community? This is something we may want to fix in 3.0.0.

Nope. I recall you filed an issue?

Not me. I thought "I've asked a question to the scancode community. Let's see what happens" meant that you filed an issue :) If there's no issue yet, I can open one.

Sorry about that! I dropped the ball. I can file an issue.

@nishakm
Copy link
Contributor

nishakm commented Feb 10, 2021

@nishakm any update from the scancode community? This is something we may want to fix in 3.0.0.

Nope. I recall you filed an issue?

Not me. I thought "I've asked a question to the scancode community. Let's see what happens" meant that you filed an issue :) If there's no issue yet, I can open one.

Sorry about that! I dropped the ball. I can file an issue.

Or if you get to it before I do, just put a link here

@rnjudge
Copy link
Contributor

rnjudge commented Jul 1, 2021

This issue should be fixed. Closing but please feel free to re-open if you notice this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something went wrong
Projects
None yet
Development

No branches or pull requests

3 participants