[BUG] Dock run error on windows (Cargo.toml)

[ToniBar]

Issue description

I try to run npx terrain deploy counter --signer validator in windows. This fails with error message on $(pwd).

Steps to reproduce the issue

1. Run npx terrain deploy counter --signer validator in windows.
2. Error message: docker: Error response from daemon: create $(pwd): "$(pwd)" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
   See 'docker run --help'.
   Error: Command failed: docker run --rm -v "$(pwd)":/code --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry
   cosmwasm/rust-optimizer:0.12.5

Tools and operating system versions

Operating system: windows 10

From what I found the error is caused because windows doesn't recognize $(pwd) and it should be %cd% instead. The docker -run call leading to this error can be found under folder /counter in file Cargo.toml. Modifying pwd to cd in this file doesn't work because this file is regenerated after every run. I have for the moment no idea where this generation happens so I am not able to modify pwd.

[emidev98]

Hey, thanks for the bug report, as soon as we get some time we'll check it!

[ToniBar]

Hey, thanks for the bug report, as soon as we get some time we'll check it!

I managed to find where the code is located. It is located in the deployment.js file in the storeCode function. The following code is called:

child_process_1.execSync(`docker run --rm -v "$(pwd)":/code \
        --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \
        --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
        cosmwasm/rust-optimizer-arm64:0.12.5`, { stdio: "inherit" });

If I remove the second line of the code and replace ¨$(pwd)" with "%cd%", then I get a built and a deployment though not 100 % correct because the second line was removed of course. So what I get is:

child_process_1.execSync(`docker run --rm -v "%cd%":/code \
        --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
        cosmwasm/rust-optimizer:0.12.5`, { stdio: "inherit" });

But the part --mount type=volume,source="$(basename "%cd%")_cache",target=/code/target \ still gives problems. No idea how to solve this. The problem is with "basename".

[ToniBar]

Hey, thanks for the bug report, as soon as we get some time we'll check it!

I fixed the basename error as well. This is my solution for windows environments:

var filename = path.basename(path.resolve(process.cwd()));
            child_process_1.execSync(`docker run --rm -v "%cd%":/code \
        --mount type=volume,source=${filename}_cache,target=/code/target \
        --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
        cosmwasm/rust-optimizer:0.12.5`, { stdio: "inherit" });

[octalmage]

Hey @ToniBar,

sorry for the delay here! Have you tried running Terrain with WSL, or is there a reason why you wouldn't be able to use WSL? In our experience using WSL can avoid these types of issues.

[octalmage]

Closing, please reopen if you're still having issues!