Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] proposal events #324

Merged
merged 1 commit into from
Mar 13, 2020
Merged

[Feature] proposal events #324

merged 1 commit into from
Mar 13, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 12, 2020

Summary of changes

  • Update SDK version to v0.37.7
  • Append treasury proposal events

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the enhancement New feature or request label Feb 12, 2020
@yun-yeo yun-yeo self-assigned this Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #324 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #324      +/-   ##
===========================================
+ Coverage    72.87%   72.95%   +0.08%     
===========================================
  Files           73       73              
  Lines         3089     3099      +10     
===========================================
+ Hits          2251     2261      +10     
  Misses         731      731              
  Partials       107      107

@yun-yeo yun-yeo merged commit 0c042c4 into develop Mar 13, 2020
@yun-yeo yun-yeo deleted the feature/proposal-events branch March 13, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant