Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Burn Address #343

Merged
merged 16 commits into from Jun 14, 2020
Merged

[Feature] Burn Address #343

merged 16 commits into from Jun 14, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 2, 2020

NOTE:: THIS MUST BE MERGED AFTER #323

Summary of changes

On the EndBlocker, check burn account balance and burn all tokens in that account. Burn account is module account with burner permission (terra1sk06e3dyexuq4shw77y3dsv480xv42mq73anxu).

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from dokwon June 2, 2020 05:15
@yun-yeo yun-yeo self-assigned this Jun 2, 2020
@yun-yeo yun-yeo added the enhancement New feature or request label Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #343 into develop will decrease coverage by 1.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    69.50%   68.46%   -1.05%     
===========================================
  Files           70       72       +2     
  Lines         3558     3618      +60     
===========================================
+ Hits          2473     2477       +4     
- Misses         948     1004      +56     
  Partials       137      137              
Impacted Files Coverage Δ
x/bank/module.go 0.00% <0.00%> (ø)
app/app.go 85.89% <100.00%> (ø)
x/bank/abci.go 100.00% <100.00%> (ø)

@hanjukim hanjukim merged commit 83c85fb into develop Jun 14, 2020
@hanjukim hanjukim added this to the Columbus-4 milestone Jun 18, 2020
@hanjukim hanjukim deleted the feature/burn-address branch June 29, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants