Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to key algorithm argument #125

Conversation

edgarsandi
Copy link
Contributor

Description

Motivation and Context

In the version 4.40.0 of the terraform-provider-aws was added support to set the key algorithm

This PR adds the support to this argument in the terraform-aws-acm module.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Signed-off-by: Edgar R. Sandi <edgar.r.sandi@gmail.com>
Signed-off-by: Edgar R. Sandi <edgar.r.sandi@gmail.com>
@bryantbiggs
Copy link
Member

all of the versions will need to be updated to reflect the version that this attribute was added in (4.40.0)

version = ">= 4.12"

Signed-off-by: Edgar R. Sandi <edgar.r.sandi@gmail.com>
Signed-off-by: Edgar R. Sandi <edgar.r.sandi@gmail.com>
@bryantbiggs bryantbiggs merged commit e35292c into terraform-aws-modules:master Dec 4, 2022
antonbabenko pushed a commit that referenced this pull request Dec 4, 2022
## [4.3.0](v4.2.0...v4.3.0) (2022-12-04)

### Features

* Add support to key algorithm argument ([#125](#125)) ([e35292c](e35292c))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.0 🎉

@liogate
Copy link

liogate commented Dec 4, 2022

Hi, this PR is maybe related to my issue ? I'm in version 4.3.0 and the key_algorithm is present indeed.

Reverting on version 4.2.0 works fine 👍

image

@bryantbiggs
Copy link
Member

what version AWS provider are you using?

@bigwheel
Copy link

bigwheel commented Dec 5, 2022

#125 (comment)
me too.
We are using 4.39.0.

provider "registry.terraform.io/hashicorp/aws" {
  version     = "4.39.0"
  constraints = ">= 2.53.0, >= 3.30.0, >= 3.56.0, >= 3.73.0, >= 4.0.0, ~> 4.0, >= 4.12.0, >= 4.30.0"
  hashes = [
    "h1:5jIAzI33opxKT6TFoAP/UVvRKvtpDe7Dsaw20go3U7w=",
    ....
    "zh:f68b2685ee86bcf314d74a20e97b5cbe0c63741827143f7a4ba7ec56555329dc",
  ]
}

@bryantbiggs
Copy link
Member

it looks like the root version was not updated like the rest of the versions - should be resolved in #126

@bigwheel
Copy link

bigwheel commented Dec 5, 2022

@bryantbiggs Agreed.
hashicorp/terraform-provider-aws#27781 shows that key_algorithm of aws_acm_certificate needs 4.40.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants