Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set correct version of AWS provider on module root #126

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: Set correct version of AWS provider on module root #126

merged 1 commit into from
Dec 8, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Dec 5, 2022 •
edited

Description

  • Set correct version on module root

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs mentioned this pull request Dec 5, 2022
Merged
3 tasks
sub2zero
sub2zero suggested changes Dec 5, 2022
View reviewed changes
Copy link

@sub2zero sub2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@antonbabenko antonbabenko changed the title fix: Set correct version on module root fix: Set correct version of AWS provider on module root Dec 8, 2022
@bryantbiggs bryantbiggs merged commit 7a0e3e3 into terraform-aws-modules:master Dec 8, 2022
@bryantbiggs bryantbiggs deleted the fix/version branch December 8, 2022 14:37
antonbabenko pushed a commit that referenced this pull request Dec 8, 2022
@semantic-release-bot
chore(release): version 4.3.1 [skip ci]
47fc8a8 
### [4.3.1](v4.3.0...v4.3.1) (2022-12-08)

### Bug Fixes

* Set correct version of AWS provider on module root ([#126](#126)) ([7a0e3e3](7a0e3e3))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.1 🎉

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sub2zero sub2zero sub2zero requested changes

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An argument named "key_algorithm" is not expected here
3 participants
@bryantbiggs @antonbabenko @sub2zero