Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed wildcard in domain names #71

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix: Fixed wildcard in domain names #71

merged 1 commit into from
Feb 19, 2021

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Feb 19, 2021

Wildcard in domain names:

Fixes #57
Fixes #67

module "example" {
  source  = "terraform-aws-modules/acm/aws"
  version = "~> v2.0"

  domain_name  = "*.api.example.com"
  zone_id      = aws_route53_zone.main.zone_id
}

Resolves #15
Resolves #47

Closes #64

Relates to #33 (Fixes #70)

@antonbabenko antonbabenko merged commit 3af7bf2 into master Feb 19, 2021
@antonbabenko antonbabenko deleted the fix-wildcards branch February 19, 2021 12:06
@antonbabenko
Copy link
Member Author

v2.13.0 has been just released.

If anyone experiences a similar or related issue, please provide the types of values you're specifying as arguments when opening a new issue.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant