Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ignore changes on tags to elasticbeanstalk:shared-elb-environment-count #324

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

mnival
Copy link
Contributor

@mnival mnival commented Nov 9, 2023

Description

Add ignore_changes to aws_lb.

Motivation and Context

To avoid this situation when we have a shared ALB with ElasticBeanstalk

  ~ resource "aws_lb" "this" {
        id                                          = "arn:aws:elasticloadbalancing:xxx:xxxx:loadbalancer/app/shared-alb/xxx"
        name                                        = "shared-alb"
      ~ tags                                        = {
          - "elasticbeanstalk:shared-elb-environment-count" = "1" -> null
            "terraform-aws-modules"                         = "alb"
        }
      ~ tags_all                                    = {
          - "elasticbeanstalk:shared-elb-environment-count" = "1" -> null
            # (4 unchanged elements hidden)
        }
        # (21 unchanged attributes hidden)

        # (5 unchanged blocks hidden)
    }```

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

do we know if this change works as intended? what are the downsides of ignoring this?

@mnival
Copy link
Contributor Author

mnival commented Nov 9, 2023

Hello,
I tested in my environment and I didn't see any regression.
This tag is describe here: https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/environments-cfg-alb-shared.html
I saw no disadvantage in ignoring it because this tag is added by AWS when we implement a shared ALB in ElasticBeanstalk

@bryantbiggs bryantbiggs changed the title feat: Add ignore changes on tags["elasticbeanstalk:shared-elb-environment-c… feat: Add ignore changes on tags to elasticbeanstalk:shared-elb-environment-count Nov 13, 2023
@bryantbiggs bryantbiggs merged commit d6715c7 into terraform-aws-modules:master Nov 13, 2023
9 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 13, 2023
## [9.2.0](v9.1.0...v9.2.0) (2023-11-13)

### Features

* Add ignore changes on tags to `elasticbeanstalk:shared-elb-environment-count` ([#324](#324)) ([d6715c7](d6715c7))
@antonbabenko
Copy link
Member

This PR is included in version 9.2.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants