Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for ALB trust store #344

Merged

Conversation

magreenbaum
Copy link
Member

Description

Closes: #342
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/mutual-authentication.html
https://aws.amazon.com/blogs/aws/mutual-authentication-for-application-load-balancer-to-reliably-verify-certificate-based-client-identities/

Motivation and Context

#342

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title feat: ALB trust store feat: Added support for ALB trust store Jan 17, 2024
@bryantbiggs
Copy link
Member

we might want to just wait for 5.33 for this bugfix hashicorp/terraform-provider-aws#35289 - should be out tomorrow (thursday) - we can raise the MSV to 5.33 for this

@antonbabenko antonbabenko merged commit 9f03c7a into terraform-aws-modules:master Jan 19, 2024
10 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 19, 2024
## [9.5.0](v9.4.1...v9.5.0) (2024-01-19)

### Features

* Added support for ALB trust store ([#344](#344)) ([9f03c7a](9f03c7a))
@antonbabenko
Copy link
Member

This PR is included in version 9.5.0 🎉

@magreenbaum magreenbaum deleted the feat/lb_trust_store branch January 19, 2024 14:15
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for mutual_authentication in aws_lb_listener
3 participants