Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for lambda_authorization_config #24

Conversation

michaelhelmick
Copy link
Contributor

@michaelhelmick michaelhelmick commented Dec 20, 2021

Description

Add lambda_authorization_config variable and dynamic argument to module.

Motivation and Context

AWS Lambda authorization was added in 3.70.0 https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appsync_graphql_api#aws-lambda-authorizer-authentication

Fixes #19

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    I haven't had a chance to test these, personally. If I get the chance before somebody else does, I will update this section.

Was able to confirm this working with a test environment:

...

module "appsync_test" {
  source = "git::https://github.com/michaelhelmick/terraform-aws-appsync.git?ref=fc3f1c257b588ff457aaa3b5a716010010ac2d06"
  schema                     = data.template_file.schema.rendered
  name                         = "appsync-test"
  authentication_type = "AWS_LAMBDA"
  lambda_authorizer_config = {
    authorizer_uri = module.authorization_lambda.arn
  }
  ...
}

Screen Shot 2021-12-20 at 12 02 12 PM

Authorized and got a successful response.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the code in examples to show this feature in action. Also, versions.tf should say 3.70.0 as a minimum because this is when this feature was added to the provider.

@antonbabenko antonbabenko changed the title Resolves #19, add lambda_authorization_config feat: Added support for lambda_authorization_config Jan 6, 2022
@michaelhelmick
Copy link
Contributor Author

@antonbabenko updated! Example, I only added the required argument

@antonbabenko antonbabenko merged commit 626d03f into terraform-aws-modules:master Jan 8, 2022
antonbabenko pushed a commit that referenced this pull request Jan 8, 2022
# [1.2.0](v1.1.2...v1.2.0) (2022-01-08)

### Features

* Added support for lambda_authorization_config ([#24](#24)) ([626d03f](626d03f))
@antonbabenko
Copy link
Member

This PR is included in version 1.2.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda authorizers
2 participants