feat: Allow more than 5 CIDRs in whitelist_unauthenticated_cidr_blocks #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
validated on my end, looks good to go @antonbabenko 👍🏽
thanks @luggage66
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jan 7, 2022
## [3.6.0](v3.5.3...v3.6.0) (2022-01-07) ### Features * Allow more than 5 CIDRs in whitelist_unauthenticated_cidr_blocks ([#220](#220)) ([df10f7b](df10f7b))
|
This PR is included in version 3.6.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow more than 5 CIDRs for the whitelist_unauthenticated_cidr_blocks field by splitting into groups of 5 (AWS's limit)
Motivation and Context
Bitbucket has 15 IPs that webhooks may come from. See: https://support.atlassian.com/organization-administration/docs/ip-addresses-and-domains-for-atlassian-cloud-products/#AtlassiancloudIPrangesanddomains-OutgoingConnections
Breaking Changes
The additional
aws_lb_listener_ruleentries will get priority+ count.indexso could collide with other listeners if the user uses those priority values.How Has This Been Tested?
I deployed this using a slightly modified github-complete from this repo, then tested upgrading to my fork and no state changes were needed. Then I added more than 5 CIDRS and confirmed correct behavior.