Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct ALB atlantis target group protocol and port arguments #375

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: Correct ALB atlantis target group protocol and port arguments #375

merged 2 commits into from
Nov 30, 2023

Conversation

pmorillas-apheris
Copy link
Contributor

Following the upgrade to Terraform ALB module major version 9, it is essential to note that the target group arguments backend_protocol and backend_port now require adjustment. Going forward, these should be replaced with protocol and port respectively.

@pmorillas-apheris pmorillas-apheris changed the title Fix ALB atlantis target group protocol and port arguments fix: Correct ALB atlantis target group protocol and port arguments Nov 30, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bryantbiggs bryantbiggs merged commit cc3e2c2 into terraform-aws-modules:master Nov 30, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 30, 2023
### [4.0.5](v4.0.4...v4.0.5) (2023-11-30)

### Bug Fixes

* Correct ALB atlantis target group protocol and port arguments ([#375](#375)) ([cc3e2c2](cc3e2c2))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.5 🎉

@pmorillas-apheris pmorillas-apheris deleted the fix_alb_target_group branch December 1, 2023 09:11
Copy link

github-actions bot commented Jan 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants