Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add 'Name' Tag to EFS File System #387

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

X-Guardian
Copy link
Contributor

Description

Add name = var.name property to the EFS module. This value is added as a tag to the EFS file system by the EFS module.

Motivation and Context

How Has This Been Tested?

  • I have tested this on my own configuration
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks for catching!

@bryantbiggs bryantbiggs merged commit fb4acfc into terraform-aws-modules:master Dec 21, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 21, 2023
### [4.0.7](v4.0.6...v4.0.7) (2023-12-21)

### Bug Fixes

* Add 'Name' Tag to EFS File System ([#387](#387)) ([fb4acfc](fb4acfc))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.7 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When EFS is Enabled, the Created EFS File System has an empty 'Name' Tag
3 participants