Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support of time_zone inside schedules #164

Merged
merged 7 commits into from
Oct 8, 2021

Conversation

ynuyasha
Copy link
Contributor

@ynuyasha ynuyasha commented Oct 8, 2021

Description

i need to create schedule with time zone defined

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@antonbabenko
Copy link
Member

Looks good. Can you also update an example to show this feature here:

schedules = {
night = {
min_size = 0
max_size = 0
desired_capacity = 0
recurrence = "0 18 * * 1-5" # Mon-Fri in the evening
}
morning = {
min_size = 0
max_size = 1
desired_capacity = 1
recurrence = "0 7 * * 1-5" # Mon-Fri in the morning
}
go-offline-to-celebrate-new-year = {
min_size = 0
max_size = 0
desired_capacity = 0
start_time = "2031-12-31T10:00:00Z" # Should be in the future
end_time = "2032-01-01T16:00:00Z"
}
}
}

@antonbabenko antonbabenko changed the title add support of time_zone inside schedules feat: Add support of time_zone inside schedules Oct 8, 2021
@ynuyasha
Copy link
Contributor Author

ynuyasha commented Oct 8, 2021

done

@antonbabenko antonbabenko merged commit 064ae6a into terraform-aws-modules:master Oct 8, 2021
@antonbabenko
Copy link
Member

Great! 🎉

v4.7.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants