fix: Make unauthorized pattern match exact #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey again @antonbabenko 👋🏼 Another change to the UnauthorizedAPICalls filter after some chats with the AWS team... More info under Motivation and Context. |
antonbabenko
pushed a commit
that referenced
this pull request
Jan 10, 2023
### [4.2.1](v4.2.0...v4.2.1) (2023-01-10) ### Bug Fixes * Make unauthorized pattern match exact ([#50](#50)) ([03d43d5](03d43d5))
|
This PR is included in version 4.2.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a parentes group from the UnauthorizedAPICalls check in the CSI framework.
Motivation and Context
So... After spending some time with the folks over at AWS support it turns out that the Security Hub checks for Metric filters in the CSI framework just check if the pattern is exactly what they have defined. No regex what so ever or validation of the pattern on sample data. So removing a parentes group to make it actually work...
Breaking Changes
No breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request