Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for period in metric_query_block #53

Conversation

magreenbaum
Copy link
Member

Description

Add support for period in metric_query_block.

Motivation and Context

hashicorp/terraform-provider-aws#29896
Update example fixtures lambda runtime to 3.9 since 3.6 is no longer supported for creating or updating lambda functions.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 19, 2023
@magreenbaum
Copy link
Member Author

Unstale

@github-actions github-actions bot removed the stale label Apr 20, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit 8dd8161 into terraform-aws-modules:master May 17, 2023
26 checks passed
antonbabenko pushed a commit that referenced this pull request May 17, 2023
## [4.3.0](v4.2.1...v4.3.0) (2023-05-17)

### Features

* Add support for `period` in `metric_query_block` ([#53](#53)) ([8dd8161](8dd8161))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.0 🎉

@magreenbaum magreenbaum deleted the feat/add_period_to_metric_query_block branch May 20, 2023 13:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants