Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Cloudwatch metric stream #64

Conversation

magreenbaum
Copy link
Member

Description

Adds a module for cloudwatch metric streams.

Motivation and Context

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch-Metric-Streams.html

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, a few comments here and there.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/metric-stream/main.tf Outdated Show resolved Hide resolved
examples/metric-stream/main.tf Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Cloudwatch metric stream feat: Added support for Cloudwatch metric stream Jan 12, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@antonbabenko antonbabenko merged commit 0aeaf26 into terraform-aws-modules:master Jan 14, 2024
32 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 14, 2024
## [5.1.0](v5.0.0...v5.1.0) (2024-01-14)

### Features

* Added support for Cloudwatch metric stream ([#64](#64)) ([0aeaf26](0aeaf26))
@antonbabenko
Copy link
Member

This PR is included in version 5.1.0 🎉

@magreenbaum magreenbaum deleted the feat/cloudwatch_metric_stream branch January 14, 2024 13:52
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants