fix: Creation of an Instance with a Capacity Reservation ID #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bryantbiggs, Would it be possible for your to review this PR ? Thanks in advance. Bests. Keep up the good work ! |
bryantbiggs
requested changes
Jul 21, 2022
added 2 commits
July 21, 2022 15:33
|
@bryantbiggs thanks for your feedback. this was due to the fact that I mistakenly removed the end of tfdocs hook in the complete example README: Now pre-commit hooks run correctly. |
bryantbiggs
reviewed
Jul 21, 2022
bryantbiggs
reviewed
Jul 21, 2022
bryantbiggs
reviewed
Jul 21, 2022
schniber
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jul 21, 2022
### [4.1.1](v4.1.0...v4.1.1) (2022-07-21) ### Bug Fixes * Creation of an Instance with a Capacity Reservation ID ([#278](#278)) ([f12ac95](f12ac95))
|
This PR is included in version 4.1.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to call the module with the specification of a Capacity Reservation ID, the module ends up with the following error:
╷
│ Error: Invalid function argument
│
│ on .terraform/modules/terraform-aws-ec2-instance/main.tf line 45, in resource "aws_instance" "this":
│ 45: capacity_reservation_id = lookup(capacity_reservation_target.value, "capacity_reservation_id", null)
│ ├────────────────
│ │ capacity_reservation_target.value is "cr-xxxxxxxx"
│
│ Invalid value for "inputMap" parameter: lookup() requires a map as the
│ first argument.
╵
As per line 45 analysis, it looks like the bug is in the following statement:
capacity_reservation_id = lookup(capacity_reservation_target.value, "capacity_reservation_id", null)
it should rather be as follows:
capacity_reservation_id = lookup(capacity_reservation_target, "capacity_reservation_id", null)
In this case, terraform should lookup in the capacity reservation target map (since it is the iterator in the for_each) rather than in its value for the mapping of the attribute capacity reservation id
Motivation and Context
Fixes #277
Breaking Changes
No breaking changes, just fixing a typo in line 45 in the main.tf
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsThis fix is hard to test since it requires to have an ongoing capacity reservation which is released by AWS.
In order to test this, I stopped at the plan stage.
pre-commit run -aon my pull request