fix: The capacity_reservation_specification default value is updated from null to {}

[schniber]

Description

The default value for the capacity_reservation_specification is now updated from null to {}

Motivation and Context

This behaviour better aligns with the general use of the module.

Breaking Changes

None

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[schniber]

As spotted by @yewton in #282
Thanks !

[bryantbiggs]

Thanks @schniber

[antonbabenko]

This PR is included in version 4.1.3 🎉

[mtraynham]

Hello, we started pulling the new module update this morning and am seeing the following. We're using the AWS Provider v4.25.0.

Downgrading back to terraform-aws-modules/ec2-instance/aws@4.1.2 still works.

╷
│ Error: Invalid combination of arguments
│
│   with module.ec2_instance["arm64"].aws_instance.this[0],
│   on .terraform/modules/ec2_instance/main.tf line 7, in resource "aws_instance" "this":
│    7: resource "aws_instance" "this" {
│
│ "capacity_reservation_specification.0.capacity_reservation_preference": one of
│ `capacity_reservation_specification.0.capacity_reservation_preference,capacity_reservation_specification.0.capacity_reservation_target` must be specified
╵

[jefteete]

getting same error as mtraynham ( Error: Invalid combination of arguments). I had to add the following to vm module to fix the issue:

capacity_reservation_specification = {
capacity_reservation_preference = "open"
}

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.