Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for creating IAM role/instance profile with policies #302

Merged
merged 3 commits into from
Nov 4, 2022
Merged

feat: Add support for creating IAM role/instance profile with policies #302

merged 3 commits into from
Nov 4, 2022

Conversation

bryantbiggs
Copy link
Member

Description

  • Add support for creating IAM role/instance profile with policies
  • Add support for providing AMI vis SSM parameter like Amazon AMIs

Motivation and Context

  • Instance profiles are the preferred means of providing permissions to instances via IAM roles for things like SSM remote access; this streamlines that experience for users
  • Amazon is moving to distributing the recommended AMI IDs via SSM Parameters and now this module supports providing just the parameter name in order to pull the appropriate AMI
  • Both of these changes together make it quite simple and easy to quickly create a secure "bastion" instance using SSM session manager (instead of SSH/PEM keys)

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

antonbabenko
antonbabenko reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Minor comment

main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit 787132e into terraform-aws-modules:master Nov 4, 2022
@bryantbiggs bryantbiggs deleted the feat/instance-profile branch November 4, 2022 14:47
antonbabenko pushed a commit that referenced this pull request Nov 4, 2022
@semantic-release-bot
chore(release): version 4.2.0 [skip ci]
cebf18a 
## [4.2.0](v4.1.4...v4.2.0) (2022-11-04)

### Features

* Add support for creating IAM role/instance profile with policies ([#302](#302)) ([787132e](787132e))
@antonbabenko
Copy link
Member

This PR is included in version 4.2.0 🎉

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryantbiggs @antonbabenko