Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for maintenance_options #312

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Dec 30, 2022

Description

Adding auto_recovery option to toggle between default and disabled. This argument is computed if not configured.
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-recover.html

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

main.tf Show resolved Hide resolved
@bryantbiggs bryantbiggs changed the title feat: Adding auto_recovery option feat: Add support for maintenance_options Jan 1, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs
Copy link
Member

Ugh, GitHub changed something with the rate limiting and now our actions are failing early. Give me a sec to fix these with a token - changes look good and we'll be able to merge straight away

@bryantbiggs bryantbiggs merged commit 2aaa990 into terraform-aws-modules:master Jan 1, 2023
antonbabenko pushed a commit that referenced this pull request Jan 1, 2023
## [4.3.0](v4.2.1...v4.3.0) (2023-01-01)

### Features

* Add support for `maintenance_options` ([#312](#312)) ([2aaa990](2aaa990))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.0 🎉

@magreenbaum magreenbaum deleted the feat/support_maintence_block_option_auto_recovery branch January 2, 2023 14:18
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instance auto_recovery option to the EC2 instance
3 participants