Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unique tags to EBS block devices #327

Merged
merged 4 commits into from Apr 21, 2023

Conversation

jebbens
Copy link
Contributor

@jebbens jebbens commented Apr 15, 2023

Description

Added tags to the ebs_block_device dynamic block.

Motivation and Context

The change is not required, however it enables users to add unique tags per block device as opposed to just the general tags applied via var.volume_tags.

Breaking Changes

This does not break backwards compatibility - it is purely additive with no additional variables.

How Has This Been Tested?

  • [ X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ X] I have tested and validated these changes using one or more of the provided examples/* projects
  • [X ] I have executed pre-commit run -a on my pull request

Used the docker version and all tests passed except the Terraform wrapper with for_each in module. The linter changed the URL in the source lines, replacing every occurrence of ec2-instance with lint, so I did not commit those changes.

@jebbens jebbens changed the title Ebs tags feat: add unique tags to ebs block devices Apr 15, 2023
@jebbens jebbens changed the title feat: add unique tags to ebs block devices feat: Add unique tags to EBS block devices Apr 15, 2023
@bryantbiggs bryantbiggs merged commit 55ed759 into terraform-aws-modules:master Apr 21, 2023
8 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 21, 2023
## [4.5.0](v4.4.0...v4.5.0) (2023-04-21)

### Features

* Add unique tags to EBS block devices ([#327](#327)) ([55ed759](55ed759))
@antonbabenko
Copy link
Member

This PR is included in version 4.5.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants