fix: Add missing tag variable in autoscaling target resource

[lays147]

Description

Add the tagsvariable into the aws_appautoscaling_target.

Motivation and Context

I'm using this module to setup an ECS Service and our checkov complained about missing tags in the aws_appautoscaling_target. This PR has the goal to add the tags to this resource.

Breaking Changes

None.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

thank you!

[antonbabenko]

This PR is included in version 5.7.1 🎉

[darrell-switch]

This seems to have broken something, haven't looked into it just yet

│   on .terraform/modules/dev.ecs_cluster_dummy/modules/service/main.tf 
| line 1205, in resource "aws_appautoscaling_target" "this":
│ 1205:   tags               = var.tags

│ An argument named "tags" is not expected here.

[lays147]

@darrell-switch that's odd. Because I have used this module with this patch, and my terraform is not broken. Maybe is the version of terraform? Or the provider?

I'm using terraform 1.6 and aws ~> 5.0 provider.

[darrell-switch]

Yep, had an old version pinned here 👍
All good 👌

[jasondamour]

Since this forces a provider update (aws v4 is no longer supported with this update), it should maybe be released as a major version. Our version regex picked up this change automatically and it broke our terraform

[bryantbiggs]

its still a v4.x provider change so no module major version required, but the MSV should have been bumped - #141

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.