fix: Adding a health_check generates a new task definition revision on every terraform apply
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on every `terraform apply`
bryantbiggs
approved these changes
Dec 21, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Dec 21, 2023
### [5.7.4](v5.7.3...v5.7.4) (2023-12-21) ### Bug Fixes * Adding a `health_check` generates a new task definition revision on every `terraform apply` ([#149](#149)) ([492e323](492e323))
|
This PR is included in version 5.7.4 🎉 |
sestrella
added a commit
to stackbuilders/terraform-aws-ecs
that referenced
this pull request
Dec 29, 2023
…revision on every `terraform apply` (terraform-aws-modules#149)" This reverts commit 492e323.
sestrella
added a commit
to stackbuilders/terraform-aws-ecs
that referenced
this pull request
Dec 29, 2023
…revision on every `terraform apply` (terraform-aws-modules#149)" This reverts commit 492e323.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current PR explicitly adds the
interval,retries, andtimeoutparameters to thehealthCheckblock when they are not supplied to prevent mismatches between the Terraform state and AWS, which results in a new task revision during eachterraform apply.Note: The default values are taken from the official documentation.
Motivation and Context
health_checkgenerates a new task definition revision on everyterraform apply#148Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request