Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand README section on ignore_task_definition_changes and Blue/Green deployments #154

Closed
andrewedstrom opened this issue Jan 25, 2024 · 5 comments
Labels

Comments

@andrewedstrom
Copy link

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

I am trying to use terraform-aws-ecs to create an ECS cluster and service that I can then deploy via GitHub actions.

The design doc is super helpful, but it has one issue that's causing me trouble.

The section on ignore_task_definition_changes says that changes to load_balancer are ignored, and after the bullet that starts with "When using the above ignore_task_definition_changes setting..." a sketch of an example configuration using codedeploy is given. Unfortunately, big chunks of the example are "omitted for brevity," which makes it harder for me to set up something similar myself.

This is tricky because without figuring it out, I'm not sure how to make my terraform both set up a load balancer and ignore changes to the task definition in the service.

Describe the solution you'd like.

I'd love to see this example expanded, with nothing omitted for brevity. Maybe it could even be turned into a full-on example in the examples/ directory.

Describe alternatives you've considered.

I'll just have to go read the docs on all the resources mentioned in the example today and try to figure out how to configure them for myself.

Additional context

n/a

Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 25, 2024
@andrewedstrom
Copy link
Author

Nooo don't close this please

@github-actions github-actions bot removed the stale label Feb 27, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 28, 2024
Copy link

github-actions bot commented Apr 7, 2024

This issue was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
Copy link

github-actions bot commented May 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant