Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring max_session_duration for the ECS Task Execution role #186

Merged

Conversation

amontalban
Copy link
Contributor

Description

This PR allows configuring the max_session_duration parameter for the ECS Task Execution Role.

Motivation and Context

This comes after the refactor done in terraform-aws-modules/terraform-aws-atlantis that had this setting in previous versions but it is now not supported.

Reference: terraform-aws-modules/terraform-aws-atlantis#300

This is the output when running terraform-aws-modules/terraform-aws-atlantis including this PR:

 # module.ecs_service.aws_iam_role.task_exec[0] will be updated in-place
  ~ resource "aws_iam_role" "task_exec" {
        id                    = "atlantis-20240402160151197700000004"
      ~ max_session_duration  = 3600 -> 43200
        name                  = "atlantis-20240402160151197700000004"
        tags                  = {
            "Config file"    = "provider/aws/shared/us-west-2/atlantis/terragrunt.hcl"
            "Created By"     = "Terragrunt"
            "Environment"    = "shared"
            "GIT Repository" = "https://github.com/ACME/terraform"
        }
        # (10 unchanged attributes hidden)
    }

Breaking Changes

It is not a breaking change.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense - though, I do hope you are able to get those plan/apply times down 😅

@bryantbiggs bryantbiggs merged commit 1b8cad1 into terraform-aws-modules:master Apr 3, 2024
11 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 3, 2024
## [5.11.0](v5.10.1...v5.11.0) (2024-04-03)

### Features

* Allow configuring max_session_duration for the ECS Task Execution role ([#186](#186)) ([1b8cad1](1b8cad1))
@antonbabenko
Copy link
Member

This PR is included in version 5.11.0 🎉

Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants