Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Complete example EC2 instance cluster joining issue #64

Merged

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 20, 2022

Description

The goal of this PR is to resolve EC2 instances not being able to successfully join the ECS cluster produced by examples/complete/ by switching enable_nat_gateway from false to true.

Motivation and Context

This PR resolves #63
The motivation is to ensure the examples can successfully bootstrap an ECS cluster and place tasks on the newly provisioned EC2 instances.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@mbeacom mbeacom changed the title Fix #63 - Adjust enable_nat_gateway to true for complete example Adjust enable_nat_gateway to true for complete example Jun 20, 2022
@mbeacom mbeacom changed the title Adjust enable_nat_gateway to true for complete example Fix complete example EC2 instance cluster joining issue Jun 20, 2022
@bryantbiggs bryantbiggs changed the title Fix complete example EC2 instance cluster joining issue fix: Complete example EC2 instance cluster joining issue Jun 20, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @mbeacom !

@bryantbiggs bryantbiggs merged commit 81a7a56 into terraform-aws-modules:master Jun 20, 2022
antonbabenko pushed a commit that referenced this pull request Jun 20, 2022
### [4.0.2](v4.0.1...v4.0.2) (2022-06-20)

### Bug Fixes

* Complete example EC2 instance cluster joining issue ([#64](#64)) ([81a7a56](81a7a56))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.2 🎉

@mbeacom mbeacom deleted the fix-63-nat-gateway branch June 20, 2022 20:19
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete example node cluster join fails
3 participants