improvement: update the wait_for_cluster_cmd
logic to use curl
if wget
doesn't exist
#1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This PR is addressing issue related to
wait_for_cluster_cmd
check which is defaulting towget
. This is brining error if you missingwget
on local system where you execute Terraform apply. This can be customized viawait_for_cluster_cmd
but usually people are not following this and meet issue. In past there was few issues opened for this:#998
#829
This PR is changing default
wait_for_cluster_cmd
to contain conditional which is checkingwget
availability, if this is missing then switch tocurl
. This logic should remediate most of issues which users meet (aswget
is available on most linux distrubution and containers, wherecurl
is available out of box in Mac OS).I have tested module on my Mac OS with
wget
available, then repeated test with unavailablewget
and availablecurl
:Execution with
wget
available:Removed
wget
Execution with
wget
unavailable:Checklist