Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a variable to add subnet tags for existing VPCs ? #1005

Closed
3 tasks
amitsehgal opened this issue Sep 9, 2020 · 2 comments
Closed
3 tasks

Is there a variable to add subnet tags for existing VPCs ? #1005

amitsehgal opened this issue Sep 9, 2020 · 2 comments

Comments

@amitsehgal
Copy link

amitsehgal commented Sep 9, 2020

I have issues

I have been using existing VPC and usually EKS tag shared is added automatically to subnets when I use this module ? I haven't seen code for it in module. My assumption is , its done by EKS service (not sure)

Is there a variable to add additional tags to existing subnets (tag is not added while creating subnets) like kubernetes.io/role/elb = 1 etc ?

I'm submitting a...

  • bug report
  • feature request
  • [* ] support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

Currently it does not add tag by default

If this is a bug, how to reproduce? Please include a code sample if relevant.

not a bug , just a query

What's the expected behavior?

looking for a pattern to add additional tag. do you suggest to use label module or null resource, local executor etc ?

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version:
  • OS:
  • Terraform version:

Any other relevant info

@amitsehgal amitsehgal changed the title Is there a variable to add subnet tags for existing VPCs Is there a variable to add subnet tags for existing VPCs ? Sep 9, 2020
@dpiddockcmp
Copy link
Contributor

This module does not modify your VPC or subnet tags

The EKS service adds some default tags to the subnets that you pass to the subnets argument.

You will need to use other terraform resources in order to modify your subnets. See the examples that use the vpc module to create VPCs with tags.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants